Skip to content

Add NFS Datastore resource in vmwareengine service #16088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
skarnawat wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add NFS Datastore resource in vmwareengine service #16088

skarnawat wants to merge 1 commit into from
+569 −0

Conversation

@skarnawat
Copy link

@skarnawat skarnawat commented Jan 7, 2026 •
edited by roaks3
Loading

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_vmwareengine_datastore`

`google_vmwareengine_datastore`

@github-actions github-actions bot requested a review from roaks3 January 7, 2026 07:33
@github-actions
Copy link

github-actions bot commented Jan 7, 2026

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions
Copy link

github-actions bot commented Jan 9, 2026

@roaks3 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions
Copy link

github-actions bot commented Jan 13, 2026

@GoogleCloudPlatform/terraform-team @roaks3 This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

@roaks3
Copy link
Contributor

roaks3 commented Jan 14, 2026

Am I correct in assuming this is a promotion from google-private? If so, were any changes needed?

@roaks3
Copy link
Contributor

roaks3 commented Jan 14, 2026

/gcbrun

@skarnawat
Copy link
Author

skarnawat commented Jan 15, 2026

Am I correct in assuming this is a promotion from google-private? If so, were any changes needed?

Yes this is promotion and no changes are required. This is my first PR so I might not be aware of all the necessary steps.

@modular-magician
Copy link
Collaborator

modular-magician commented Jan 15, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1629 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1629 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 245 insertions(+))

Missing doc report (experimental)

The following data sources are missing documents:

  • google_vmwareengine_datastore, expect file /website/docs/d/vmwareengine_datastore.html.markdown to exist.

@modular-magician
Copy link
Collaborator

modular-magician commented Jan 15, 2026

Tests analytics

Total tests: 15
Passed tests: 7
Skipped tests: 5
Affected tests: 3

Click here to see the affected service packages
  • vmwareengine

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccVmwareengineDatastore_vmwareEngineDatastoreFilestore_update
  • TestAccVmwareengineDatastore_vmwareEngineDatastoreNetapp_update
  • TestAccVmwareengineDatastore_vmwareEngineDatastoreThirdparty_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

modular-magician commented Jan 15, 2026

🟢 Tests passed during RECORDING mode:
TestAccVmwareengineDatastore_vmwareEngineDatastoreFilestore_update [Debug log]
TestAccVmwareengineDatastore_vmwareEngineDatastoreThirdparty_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccVmwareengineDatastore_vmwareEngineDatastoreNetapp_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

roaks3
roaks3 reviewed Jan 15, 2026
View reviewed changes
Copy link
Contributor

@roaks3 roaks3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you also need to add a docs page for the datasource. You can usually copy-and-paste one from a similar resource and go from there.

Also, for the netapp test failure, we're seeing Error creating volume - Specified pool is in deleting state, hence volume cannot be created.

It's not obvious to me what's going on, the pool seems to be created correctly and then the volume call fails fairly quickly after. Is there some reason the pool would be destroyed almost immediately by the server? Or perhaps we need some sort of delay before trying to create the volume?

mmv1/templates/terraform/examples/vmware_engine_datastore_filestore.tf.tmpl Outdated
@@ -0,0 +1,18 @@
# Use existing filestore instance
data "google_filestore_instance" "test_instance" {
name = "tf-test-datastore-fs-instance"
Copy link
Contributor

@roaks3 roaks3 Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: "tf-test" prefix shouldn't be needed, since this is only a docs example

Copy link
Author

@skarnawat skarnawat Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

mmv1/third_party/terraform/services/vmwareengine/data_source_google_vmwareengine_datastore.go
@@ -0,0 +1,40 @@
package vmwareengine
Copy link
Contributor

@roaks3 roaks3 Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider seeing if using an autogenerated datasource works for you (I would basically try a generation and see if the resulting diff matches your file, or very close). In the mmv1/products/vmwareengine/Datastore.yaml:

datasource:
  generate: true
  exclude_test: true

Copy link
Author

@skarnawat skarnawat Jan 16, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per this article https://googlecloudplatform.github.io/magic-modules/develop/add-handwritten-datasource/#add-a-datasource only handwritten datasource are supported.

I have added autogenerate config in mmv1/products/vmwareengine/Datastore.yaml however make provider is not auto generating datasource file.

@github-actions github-actions bot requested a review from roaks3 January 16, 2026 04:26
@modular-magician
Copy link
Collaborator

modular-magician commented Jan 16, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 1738 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 8 files changed, 1738 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 245 insertions(+))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@modular-magician
Copy link
Collaborator

modular-magician commented Jan 16, 2026

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccVmwareengineDatastore_vmwareEngineDatastoreFilestore_update
  • TestAccVmwareengineDatastore_vmwareEngineDatastoreNetapp_update
  • TestAccVmwareengineDatastore_vmwareEngineDatastoreThirdparty_update

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • vmwareengine

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roaks3 roaks3 Awaiting requested review from roaks3

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

service/vmwareengine

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@skarnawat @roaks3 @modular-magician